Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue_fix #4285

Closed
wants to merge 6 commits into from
Closed

Issue_fix #4285

wants to merge 6 commits into from

Conversation

glo82145
Copy link
Collaborator

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Jun 27, 2024
@glo82145 glo82145 changed the base branch from develop to release/14.1 June 27, 2024 10:29
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jun 27, 2024

Fails
🚫

node failed.

🚫 A version label is required. A maintainer must add one.
🚫

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/peregrine/lib/hooks/useCustomerWishlistSkus/__tests__/useCustomerWishlistSkus.spec.js
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing information in PR. Please fill out the "Description" section.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 0bda90e

glo42707
glo42707 previously approved these changes Jun 27, 2024
Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for 14.1 release

@glo82145
Copy link
Collaborator Author

run coverage/coveralls

@glo82145 glo82145 changed the base branch from release/14.1 to develop June 27, 2024 11:19
@glo82145 glo82145 dismissed glo42707’s stale review June 27, 2024 11:19

The base branch was changed.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Review in Progress in Pull Request Progress Jun 27, 2024
@glo82145 glo82145 changed the base branch from develop to release/14.1 June 27, 2024 11:20
@glo82145
Copy link
Collaborator Author

run coveralls-develop

@glo82145 glo82145 changed the base branch from release/14.1 to develop June 27, 2024 11:28
@glo82145 glo82145 changed the base branch from develop to release/14.1 June 27, 2024 11:45
@glo82145
Copy link
Collaborator Author

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 27, 2024

Successfully started codebuild job for pr-test

@m2-community-project m2-community-project bot removed this from Review in Progress in Pull Request Progress Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants