Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3216::upgarding node 14 to 18 #4279

Merged
merged 5 commits into from
Jun 25, 2024
Merged

PWA-3216::upgarding node 14 to 18 #4279

merged 5 commits into from
Jun 25, 2024

Conversation

glo82145
Copy link
Collaborator

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jun 10, 2024

Fails
🚫 A version label is required. A maintainer must add one.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing information in PR. Please fill out the "Description" section.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 20bf0a0

@glo82145
Copy link
Collaborator Author

run scaffold-pwa

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 12, 2024

Successfully started codebuild job for scaffold-pwa

@glo82145
Copy link
Collaborator Author

run pr-deploy

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 12, 2024

Successfully started codebuild job for pr-deploy

@glo82145
Copy link
Collaborator Author

run pr-deploy

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 12, 2024

Successfully started codebuild job for pr-deploy

@glo82145
Copy link
Collaborator Author

run scaffold-pwa

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 12, 2024

Successfully started codebuild job for scaffold-pwa

@glo82145
Copy link
Collaborator Author

run pr-deploy

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 12, 2024

Successfully started codebuild job for pr-deploy

@glo82145
Copy link
Collaborator Author

run pr-build

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 12, 2024

Successfully started codebuild job for pr-build

Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@glo82145 glo82145 added version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump. version: Minor This changeset includes functionality added in a backwards compatible manner. and removed version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump. labels Jun 25, 2024
@glo82145 glo82145 merged commit e7eeba2 into develop Jun 25, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:babel-preset-peregrine pkg:pagebuilder pkg:peregrine pkg:pwa-buildpack pkg:upward-js Pertains to upward-js reference implementation of UPWARD. pkg:upward-spec Pertains to UPWARD specification package. pkg:venia-concept pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants