Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA-3264:PDP breadcrumbs only show one level of product category #4277

Merged
merged 2 commits into from
Jul 30, 2024
Merged

PWA-3264:PDP breadcrumbs only show one level of product category #4277

merged 2 commits into from
Jul 30, 2024

Conversation

glo11372
Copy link
Collaborator

@glo11372 glo11372 commented Jun 7, 2024

Description

  1. Go to the venia site clike any category like bottoms->pants-> any product, so now on PDP page full breadcrumbs is visible.

Related Issue

Closes #4261

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo11372 glo11372 added pkg:peregrine version: Minor This changeset includes functionality added in a backwards compatible manner. labels Jun 7, 2024
@glo11372 glo11372 requested a review from glo82145 June 7, 2024 10:43
@glo11372 glo11372 self-assigned this Jun 7, 2024
@glo11372 glo11372 added version: Patch This changeset includes backwards compatible bug fixes. and removed version: Minor This changeset includes functionality added in a backwards compatible manner. labels Jun 7, 2024
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jun 7, 2024 •
edited
Loading

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against e2cb766

@glo11372 glo11372 added pkg:venia-ui version: Minor This changeset includes functionality added in a backwards compatible manner. bug Something isn't working and removed version: Patch This changeset includes backwards compatible bug fixes. pkg:venia-ui labels Jun 7, 2024
@glo82145
Copy link
Collaborator

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jul 12, 2024

Successfully started codebuild job for pr-test

@glo82145
Copy link
Collaborator

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jul 29, 2024

Successfully started codebuild job for pr-test

@glo82145
Copy link
Collaborator

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jul 30, 2024

Successfully started codebuild job for pr-test

@glo82145 glo82145 merged commit 65f1beb into develop Jul 30, 2024
7 checks passed
@glo82145 glo82145 deleted the PWA-3264-testv1 branch July 30, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glo82145 glo82145 glo82145 approved these changes

Assignees

@glo82145 glo82145

@glo11372 glo11372

Labels
bug Something isn't working pkg:peregrine Progress: approved Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
Pull Request Progress
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: PDP breadcrumbs only show one level of product category
3 participants
@glo11372 @pwa-studio-bot @glo82145