Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pwa 3264-PDP breadcrumbs only show one level of product category #4276

Closed
wants to merge 7 commits into from

Conversation

glo11372
Copy link
Collaborator

@glo11372 glo11372 commented Jun 5, 2024

Description

  1. Try to make categories and sub categories then click on product, on PDP page Full breadcrumbs will be visible now

Related Issue

Closes #4261

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo11372 glo11372 added pkg:peregrine version: Minor This changeset includes functionality added in a backwards compatible manner. labels Jun 5, 2024
@glo11372 glo11372 requested a review from glo82145 June 5, 2024 10:51
@glo11372 glo11372 self-assigned this Jun 5, 2024
@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Unable to build scaffolded project.

yarn build

within a scaffolded project directory failed.
Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/.

🚫

GraphQL queries did not pass. Make sure to execute yarn run validate-queries locally prior to committing.

🚫

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/peregrine/lib/targets/__tests__/peregrine-targets.spec.js
  • packages/pwa-buildpack/lib/Utilities/__tests__/configureHost.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/RootComponentsPlugin.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/LocalizationPlugin.spec.js
  • packages/venia-ui/lib/targets/__tests__/venia-ui-targets.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/UpwardIncludePlugin.spec.js
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests


ERROR ON TASK: validateQueries


ERROR ON TASK: scaffoldingSucceeds


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against e668d31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: PDP breadcrumbs only show one level of product category
3 participants