Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX#PWA-3161 [Cloud] Search Term Redirect not working in PWA #4169

Closed
wants to merge 1 commit into from

Conversation

RaghavendraTirumalasetti
Copy link
Contributor

Description

Search term redirects are not working in PWA

STEPS TO REPLICATE:

  1. Vanilla install with PWA

  2. Marketing SEO & Search >Search Terms

  3. Add New Search Term

  4. Search Query: Test URL: https://icanhazip.com/

  5. Save

  6. Load frontend

  7. Search Test

EXPECTED RESULTS:

Get redirected to - https://icanhazip.com/

ACTUAL RESULTS:
Am not redirected to - https://icanhazip.com/

Related Issue

Closes #https://jira.corp.adobe.com/browse/PWA-3161.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫 A version label is required. A maintainer must add one.
🚫

GraphQL queries did not pass. Make sure to execute yarn run validate-queries locally prior to committing.

Messages
📖

Associated JIRA tickets: PWA-3161.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: validateQueries


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 718bda0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants