Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA-3172: [bug]: Regions select stuck in loading state in checkout when US is disabled #4156

Closed
wants to merge 3 commits into from
Closed

PWA-3172: [bug]: Regions select stuck in loading state in checkout when US is disabled #4156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
850ca8b
PWA-3172: Fixed Regions select stuck issue
Tarun50745 Aug 17, 2023
3ac36d8
PWA-3172: Test cases coverage
Tarun50745 Aug 17, 2023
7c6b46e
PWA-3172: updated Test case snapshots
Tarun50745 Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/peregrine/lib/talons/Region/__tests__/__snapshots__/useRegion.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,6 @@ Object {
exports[`should return loading state if data is not available 1`] = `
Object {
"loading": false,
"regions": Array [
Object {
"label": "Loading Regions...",
"value": "",
},
],
"regions": Array [],
}
`;
8 changes: 8 additions & 0 deletions packages/peregrine/lib/talons/Region/useRegion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,14 @@ export const useRegion = props => {
formattedRegionsData = [];
}
}
// If data is undefined or not present
else {
formattedRegionsData = [];
}
// state field label till data is loading ...
if (loading) {
formattedRegionsData = [{ label: 'Loading Regions...', value: '' }];
}

return {
loading,
Expand Down