Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGREQ-8593: Removed reference to old GH org #4151

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

jeff-matthews
Copy link
Contributor

Description

Related to #4146

References to the magento-devdocs org must be replaced with the correct Adobe-owned org (commerce-docs).

Related Issue

MAGREQ-8593
VULN-25329

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: MAGREQ-8593.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against ef88f4e

@jeff-matthews
Copy link
Contributor Author

@glo42707 & @glo82145, will you please help me get this merged? I think it's the last update we need to resolve the issues reported in the ticket.

Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@glo82145
Copy link
Collaborator

glo82145 commented Aug 4, 2023

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 4, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145
Copy link
Collaborator

glo82145 commented Aug 4, 2023

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 4, 2023

Successfully started codebuild job for lighthouse-desktop

@jeff-matthews
Copy link
Contributor Author

@glo82145, the Danger_CI_Checks test is failing with the following message:

A version label is required. A maintainer must add one.

Can you please fix this error and merge?

@glo82145 glo82145 added the version: Patch This changeset includes backwards compatible bug fixes. label Aug 10, 2023
@glo82145 glo82145 merged commit 0ddf8f0 into magento:develop Aug 10, 2023
11 of 12 checks passed
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Aug 10, 2023
@jeff-matthews jeff-matthews deleted the MAGREQ-8593-devdocs branch August 10, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants