Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3085::[PWA]Different error message on shopping page and in edit pop-up #4135

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Jun 21, 2023

Description

When a user tries to update the quantity of an item in the shopping cart page and Edit Item popup to a value that exceeds the salable quantity available, the website display different error messages on FE, even though both operations return the same error message.

Related Issue

Closes #PWA-3085

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Jun 21, 2023
@glo82145 glo82145 added the version: Patch This changeset includes backwards compatible bug fixes. label Jun 21, 2023
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jun 21, 2023

Messages
📖

Associated JIRA tickets: PWA-3085.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 8ca3903

@glo82145
Copy link
Collaborator Author

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 21, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator Author

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 21, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145 glo82145 merged commit 297ba0d into develop Sep 21, 2023
11 checks passed
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants