Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3160 :: Search Bar Conflicting with Categories and Sub-Categories #4133

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

Tarun50745
Copy link
Contributor

Description

When a user has an active search displayed or the search bar is visible, the category dropdowns are not accessible. If a user tries to present the category dropdowns, and moves the cursor toward once of the sub-categories, they disappear.

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3160.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jun 20, 2023

Messages
📖

Associated JIRA tickets: PWA-3160.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 7d22757

@Tarun50745 Tarun50745 self-assigned this Jun 21, 2023
@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Jun 21, 2023
@Tarun50745 Tarun50745 requested a review from glo82145 June 21, 2023 05:23
@Tarun50745 Tarun50745 added version: Minor This changeset includes functionality added in a backwards compatible manner. Progress: ready for review and removed Progress: review labels Jun 21, 2023
@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Review in Pull Request Progress Jun 21, 2023
@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Jun 21, 2023
@Tarun50745 Tarun50745 added version: Patch This changeset includes backwards compatible bug fixes. and removed version: Minor This changeset includes functionality added in a backwards compatible manner. labels Jun 27, 2023
@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Jun 28, 2023
@glo82145
Copy link
Collaborator

glo82145 commented Oct 4, 2023

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 4, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145
Copy link
Collaborator

glo82145 commented Oct 4, 2023

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 4, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator

glo82145 commented Oct 4, 2023

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 4, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145 glo82145 merged commit 0c3cd48 into develop Oct 4, 2023
11 checks passed
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants