Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added release notes #4132

Merged
merged 6 commits into from
Jun 20, 2023
Merged

Added release notes #4132

merged 6 commits into from
Jun 20, 2023

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Jun 15, 2023

Description

Release notes for PWA Studio 13.2.0

Related Issue

Closes #https://jira.corp.adobe.com/browse/PWA-3146

Acceptance

Verification Stakeholders

Verification Steps

Check changlog.md for accuracy.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jun 15, 2023

Messages
📖

Associated JIRA tickets: PWA-3146.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 77e2270

@glo82145 glo82145 requested a review from bdenham June 15, 2023 09:00
CHANGELOG.md Outdated
- **PHP 8.2 support** — PWA Studio now supports PHP 8.2. GitHub PRs: [4][], [25][], [34][], [5][], [20][], [10][]
- **Payment method persists** — The chosen payment method now persists throughout the user's session. GitHub PR: [3969][]
- **Node 18 support** — PWA Studio now supports Node 18.0,0+. GitHub PR: [172][]
The 13.0 release of PWA Studio provides customers with many accessibility improvements for keyboard and screen-reader access, as well as several bug fixes. Full details are described below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should say the 13.2.0 release of PWA Studio

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been done

Copy link
Contributor

@supernova-at supernova-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor fix but other than that it looks great!

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Request Progress Jun 15, 2023
@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in Pull Request Progress Jun 15, 2023
glo42707
glo42707 previously approved these changes Jun 16, 2023
Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Jun 16, 2023
@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to use radio-boolean filter results in Category and Search pages:
    • AssertionError: Timed out retrying after 30000ms: Expected to find content: 'No' within the element: [
    • , 1 more... ] and with the selector: '[data-cy="RadioGroup-root"] label[class^="radio-root-"]' but never did.
  • user should be able to add and remove promotions from cart:
    • AssertionError: Timed out retrying after 30000ms: Expected not to exist in the DOM, but it was continuously found.
  • should be able to edit a configurable product and place an order:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CreditCard-root"] [id*="braintree-hosted-field-cardholderName"]`, but never found it.
  • user should be able to place an order as a registered customer:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlGetCustomerAfterCreateQuery`. No request ever occurred.

      https://on.cypress.io/wait


    Registered user should be able to sign in from toast suggestion in guest checkout page:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="Toast-root"], but never found it.
  • user can fill and submit payment form and place order with inline badge position:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="CreditCard-root"] [id*="braintree-hosted-field-cardholderName"], but never found it.

    user can fill and submit payment form and place order with default badge position:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="CreditCard-root"] [id*="braintree-hosted-field-cardholderName"], but never found it.
  • user should be able to place an order as a guest with an specified Region and a credit card:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlGetSelectedAndAvailableShippingMethodsQuery. No request ever occurred.

      https://on.cypress.io/wait

  • user should be able to add and remove products from wishlist:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlSignInAfterCreateMutation. No request ever occurred.

      https://on.cypress.io/wait

  • should be able to place an order in French store:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="ProductOptions-Option-root"], but never found it.

    should display English text and USD currency accross app if Default Store View is selected:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlSignInAfterCreateMutation. No request ever occurred.

      https://on.cypress.io/wait


    should display French text and EUR currency accross app if French Store View is selected:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="ProductFullDetail-root"] [data-cy="ProductOptions-Option-root"] [data-cy="ProductOptions-Option-selectedLabel"], but never found it.

    should show USD currency across app if it is selected inside French Store View:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="ProductFullDetail-root"] [data-cy="ProductFullDetail-productPrice"], but never found it.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 77e2270

@glo82145 glo82145 changed the base branch from release/13.2 to develop June 20, 2023 12:37
@glo82145 glo82145 dismissed stale reviews from supernova-at and glo42707 June 20, 2023 12:37

The base branch was changed.

@m2-community-project m2-community-project bot added this to Review in Progress in Pull Request Progress Jun 20, 2023
@glo82145 glo82145 changed the base branch from develop to release/13.2 June 20, 2023 12:38
@glo82145 glo82145 changed the base branch from release/13.2 to develop June 20, 2023 12:39
@glo42707 glo42707 self-requested a review June 20, 2023 12:40
glo42707
glo42707 previously approved these changes Jun 20, 2023
Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for develop PR Merge test

@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Jun 20, 2023
@glo82145 glo82145 changed the base branch from develop to release/13.2 June 20, 2023 12:45
@glo82145 glo82145 dismissed glo42707’s stale review June 20, 2023 12:45

The base branch was changed.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Review in Progress in Pull Request Progress Jun 20, 2023
@glo82145 glo82145 requested a review from glo42707 June 20, 2023 12:45
Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving again for release/13.2 branch test if able to merge

@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Jun 20, 2023
@glo82145 glo82145 merged commit 90a04e3 into release/13.2 Jun 20, 2023
1 check passed
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Jun 20, 2023
@glo82145 glo82145 deleted the release-notes branch June 20, 2023 13:02
glo82145 added a commit that referenced this pull request Jun 22, 2023
* v13.2.0-alpha.1

* v13.2.0-beta.1

* Added release notes (#4132)

* Added release notes

* Added release notes

* Added release notes

* Added release notes

* v13.2.0-beta.2

* v13.2.0

---------

Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation needs triage Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants