Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pwa 3137 #4128

Closed
wants to merge 2 commits into from
Closed

Pwa 3137 #4128

wants to merge 2 commits into from

Conversation

glo80771
Copy link
Contributor

@glo80771 glo80771 commented Jun 6, 2023

Description

If a row added in pagebuilder contains a background image configured with the parallax option, the image will show up on other pages even if the row was not added to the page in question. This issue is not reproducible on LUMA, only on PWA.

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3137.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: PWA-3137.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 4b159a2

@glo80771 glo80771 added the version: Patch This changeset includes backwards compatible bug fixes. label Jun 6, 2023
@glo80771 glo80771 closed this Jun 6, 2023
@glo80771 glo80771 deleted the PWA-3137 branch June 6, 2023 14:25
@m2-community-project m2-community-project bot removed this from Ready for Review in Pull Request Progress Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:pagebuilder pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants