Pwa 3139 v2 #4124
Merged
Pwa 3139 v2 #4124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Magento , and is not required on normal storefront
|
glo80771
added
the
version: Patch
…ll issue for credit card payment mode
…ll issue for credit card payment method
glo82145
reviewed
Jun 5, 2023
| if (shippingAddress.region == null) { | ||
| shippingAddress.region = ''; | ||
| } | ||
|
|
| ? mapAddressData(shippingAddressData.cart.shippingAddresses[0]) | ||
| : {}; | ||
|
|
||
| if (shippingAddress.region == null) { |
| createErrorMessage?.includes(errorMessage) || | ||
| updateErrorMessage?.includes(errorMessage); | ||
|
|
||
| // errors |
m2-community-project
bot
moved this from Ready for Review
to Review in Progress
in Pull Request Progress
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
glo82145
requested changes
Jun 5, 2023
glo82145
requested changes
Jun 5, 2023
m2-community-project
bot
moved this from Review in Progress
to Changes Requested
in Pull Request Progress
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
glo82145
approved these changes
Jun 5, 2023
glo82145
approved these changes
Jun 5, 2023
m2-community-project
bot
moved this from Changes Requested
to Reviewer Approved
in Pull Request Progress
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
|
run lighthouse-desktop |
|
Successfully started codebuild job for |
|
run lighthouse-mobile |
|
Successfully started codebuild job for |
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Region is required in PWA although this option is disabled in Magento , and is not required on normal storefront .
A clear and concise description of what the bug is.
Steps to reproduce the behavior:
Set default country to United Kingdom , disable State is Required for UK .
Try to create order , in SHIPPING INFORMATION - state will be required ,
Related Issue
Closes https://jira.corp.adobe.com/browse/PWA-3139.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist