Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redirect to blank/outdated datasetId #597

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Fix redirect to blank/outdated datasetId #597

merged 1 commit into from
Mar 16, 2018

Conversation

steve9164
Copy link
Member

@steve9164 steve9164 commented Mar 15, 2018 •
edited
Loading

What this PR does

Fixes #572
Fixes #589

Checklist

  • Unit tests aren't applicable
  • I've updated CHANGES.md with what I changed. not really applicable (was only broken for a couple of days)
  • I've linked this PR to an issue in ZenHub (or there is no issue) and dragged it to the Pull Request column

@steve9164
Copy link
Member Author

steve9164 commented Mar 15, 2018 •
edited
Loading

I've used encodeURI here with the thought that encodeURI . decodeURI == id. (Relevant because this issue states that decodeURI is applied to params).

Sounds reasonable to me, but I'm not 100% sure that's correct.

@AlexGilleran AlexGilleran merged commit 57fce33 into master Mar 16, 2018
@AlexGilleran AlexGilleran deleted the fix_record_redirect branch March 16, 2018 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steve9164 @AlexGilleran