Fixing the "usage" example as it's wrong #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage example has a mistake and makes it so that when people do copy/paste, they end up with a wrong example.
Closed
|
You need both namespaces - |
|
This is not really correct. Usage with reagent is lower. To improve readability we can probably rename first "Usage" to "Usage with Om" and make "Using with Reagent" header bigger |
|
Wow, I completely overlooked that as well :( Suggestion: a table of contents on the top, to bring people's attention to the fact that there are multiple guides for setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage example has a mistake and makes it so that when people do copy/paste, they end up with a wrong example.