macOS: Fix emitting Event::LoopDestroyed on CMD+Q / Quit

Fixes rust-windowing#1998 Alternative: rust-windowing#2073
madsmtm · Mar 21, 2022 · 208e433 · 208e433
1 parent e22c76b
commit 208e433
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@ And please only add new entries to the top of this list, right below the `# Unre
 
 # Unreleased
 
+- macOS: Fix emitting `Event::LoopDestroyed` on CMD+Q.
 - macOS: Remove the need to call `set_ime_position` after moving the window.
 - Added `Window::is_visible`.
 - Added `Window::is_resizable`.

diff --git a/src/platform_impl/macos/menu.rs b/src/platform_impl/macos/menu.rs
@@ -77,7 +77,10 @@ pub fn initialize() {
         let quit_item_title = quit_item_prefix.stringByAppendingString_(process_name);
         let quit_item = menu_item(
             quit_item_title,
-            selector("terminate:"),
+            // Ususally `terminate:` would be used, however, we would probably
+            // like `run_return` to be able to keep going after the application
+            // was quit.
+            selector("stop:"),
             Some(KeyEquivalent {
                 key: "q",
                 masks: None,