Fixing issue #1318 #1319
Closed
Fixing issue #1318 #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontrollanten
approved these changes
Jan 28, 2018
kontrollanten
added a commit
to kontrollanten/algolia-places-react
that referenced
this pull request
Jan 28, 2018
Workaround while waiting for madrobby/zepto#1319
kontrollanten
added a commit
to kontrollanten/algolia-places-react
that referenced
this pull request
Jan 28, 2018
Workaround while waiting for madrobby/zepto#1319
src/event.js
Outdated
| e.data = data | ||
| var dataPropDescriptor = Object.getOwnPropertyDescriptor(e, 'data') | ||
| if (!dataPropDescriptor || dataPropDescriptor.writable) | ||
| e.data = data |
There was a problem hiding this comment.
It seems that when using strict mode dataPropDescriptor will be undefined when e is InputEvent (even though data property exists). Seems like a bug to me. To workaround this I would propose to wrap this line around a try/catch and add a comment about this.
kontrollanten
approved these changes
Jan 29, 2018
Haroenv
approved these changes
Feb 7, 2018
|
why this fixed is not merged? |
|
Do I need to do anything? Why isn't it merged already? |
Kocal
added a commit
to Yproximite/algolia-places-with-fixed-zepto
that referenced
this pull request
Oct 16, 2018
Kocal
added a commit
to Yproximite/algolia-places-with-fixed-zepto
that referenced
this pull request
Oct 16, 2018
fix: apply patch madrobby/zepto#1319
Kocal
added a commit
to Kocal/autocomplete.js
that referenced
this pull request
Oct 31, 2018
Haroenv
pushed a commit
to algolia/autocomplete
that referenced
this pull request
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some event object have readonly data property - I've added test for that.
#1318