-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental Event InputEvent
has readonly data
attribute
#1256
Labels
Comments
Closing this as I can't reproduce. |
"use strict" will cause this bug and you should update chrome to 60+ or iOS 10.3+ ... I reproduced it too @madrobby |
I'm also have same issue with jquery ) |
This issue is happening if you add an event to the |
Same issue today, with Chrome 68. Nothing in dev environment, but the error is fired on production (webpack 4). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I started getting
Uncaught TypeError: Cannot assign to read only property 'data' of object '#<InputEvent>'
with a flag on chrome.This line being the culprit https://github.com/madrobby/zepto/blob/master/src/event.js#L68
The new
InputEvent
spec has an actualdata
attribute, clashing with Zepto's.Seems like the real fix would be to deprecate
data
on the event and use something else, or return a custom event instead of modifying the DOM Event itself.It will because a big problem soon when this is not experimental I believe.
cc @maximebedard @Krystosterone
The text was updated successfully, but these errors were encountered: