TW-1461: [EVM][QA] Final arch prep epic QA #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from chain. Refactor EVM Balances loading state
…ata loading by falling back to loading from chain
…Y as a leading asset
…e. Rate wasnt loading for users with 0 balance
…ess cycles in collectibles rendering
…ess cycles in tokens rendering
…ix metadata loading for multichain view
…ogic hooks. Fix grouping in manage active tab
keshan3262
reviewed
Aug 9, 2024
src/app/hooks/listing-logic/use-tezos-chain-collectibles-listing-logic.ts
Outdated
Show resolved
Hide resolved
| // Polygon Testnet | ||
| /** Polygon Testnet | ||
| * @deprecated https://www.alchemy.com/blog/polygon-mumbai-testnet-deprecation | ||
| */ | ||
| 80001: '0x0000000000000000000000000000000000001010' |
There was a problem hiding this comment.
Should we add Amoy testnet in this case?
There was a problem hiding this comment.
No, Amoy has default value for this fake gas token address (see above in code):
const DEFAULT_NATIVE_TOKEN_ADDRESS = '0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee';
src/lib/assets/hooks/collectibles.ts
Outdated
|
|
||
| export const useAllTezosChainAccountCollectiblesSlugs = (publicKeyHash: string, chainId: string) => { | ||
| const collectibles = useTezosChainAccountCollectibles(publicKeyHash, chainId); | ||
| for (const [slug, { status }] of Object.entries(stored)) { |
There was a problem hiding this comment.
Should we use Object.entries(stored).filter(...).map(...) here instead for better performance?
src/lib/assets/hooks/collectibles.ts
Outdated
|
|
||
| export const useAllEvmChainAccountCollectiblesSlugs = (publicKeyHash: HexString, evmChainId: number) => { | ||
| const collectibles = useEvmChainAccountCollectibles(publicKeyHash, evmChainId); | ||
| for (const [slug, { status }] of Object.entries(stored)) { |
There was a problem hiding this comment.
Here is the same code as for the comment above, please consider additional refactoring
| @@ -188,15 +188,6 @@ export const EVM_DEFAULT_NETWORKS: NonEmptyArray<StoredEvmNetwork> = [ | |||
| color: '#010b79', | |||
| default: true | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Please consider adding Amoy testnet here too
alex-tsx
force-pushed
the
TW-1461-evm-final-epic-qa
branch
from
fa6f009
to
5def207
Compare
lendihop
reviewed
Aug 12, 2024
lendihop
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://madfish.atlassian.net/browse/TW-1461