Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for relevance model #80

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Hotfix for relevance model #80

merged 5 commits into from
Jan 24, 2024

Conversation

p-ferreira
Copy link
Contributor

@p-ferreira p-ferreira commented Jan 24, 2024

It seems that we need self.model.cuda() to bring the model into memory. This function brings the model to the device specified on the model initialization, and it's defined in the angle lib as:

    def cuda(self):
        if self.load_kbit is None:
            self.backbone = self.backbone.to(torch.device(self.device))
        return self

Without model.cuda(), the test validator was throwing the classic exception tensors are not in the same device (gpu and cpu) on encoding

Other changes included in the PR:

  • normalizes configs for miners
  • adds README for wiki agent and zephyr miner
  • overall adjustments on dependencies and wiki agent

Copy link
Collaborator

@steffencruz steffencruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Looks good to me

@p-ferreira p-ferreira merged commit f09505d into staging Jan 24, 2024
3 checks passed
@mccrindlebrian mccrindlebrian deleted the hotfix/relevance-device branch April 16, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants