Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check untyped defs #390

Merged
merged 1 commit into from
Aug 3, 2024
Merged

check untyped defs #390

merged 1 commit into from
Aug 3, 2024

Conversation

kitagry
Copy link
Member

@kitagry kitagry commented Aug 3, 2024

strict check for mypy

@@ -66,6 +66,8 @@ quote-style = "single"
ignore_missing_imports = true
plugins = ["gokart.mypy:plugin"]

check_untyped_defs = true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turn on check_untyped_defs option.

@kitagry kitagry marked this pull request as ready for review August 3, 2024 02:59
Copy link
Contributor

@hiro-o918 hiro-o918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hirosassa hirosassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good👍

Copy link
Collaborator

@yokomotod yokomotod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job ! towards strict = true ...

@kitagry kitagry merged commit 174e153 into master Aug 3, 2024
5 checks passed
@kitagry kitagry deleted the mypy-check-untyped-defs branch August 3, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants