allow distributing typed information #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokomotod
reviewed
Mar 1, 2024
pyproject.toml
Outdated
Comment on lines
12
to
13
| {include = "gokart"}, | ||
| {include = "gokart/py.typed"}, |
There was a problem hiding this comment.
@dn070017 [question]
include = "gokart" doesn't include gokart/py.typed ?
I'm not sure but include = "gokart" sounds include = "gokart/*" which includes gokart/py.typed ...?
There was a problem hiding this comment.
@yokomotod
Yes, I think you are correct. After investigate into the behavior for this setting, it turns out that Poetry includes every file under the source directory by default. I think it should be fine to revert the changes I made in pyproject.toml.
mski-iksm
added a commit
to mski-iksm/gokart
that referenced
this pull request
Mar 17, 2024
delete RunWithLock delete old codes add test sort sort delete move rename test rename Change build backend to poetry-core (m3dev#355) Co-authored-by: Keisuke Ogaki <keisuke-ogaki@m3.com> allow distributing typed information (m3dev#356) * allow distributing typed information * restore include relax python constraint (m3dev#357) relock add Update docs/efficient_run_on_multi_workers.rst Co-authored-by: Keisuke OGAKI <hikingko1@gmail.com> set complete_check_at_run=False
kitagry
pushed a commit
that referenced
this pull request
Mar 22, 2024
* add task run lock delete RunWithLock delete old codes add test sort sort delete move rename test rename Change build backend to poetry-core (#355) Co-authored-by: Keisuke Ogaki <keisuke-ogaki@m3.com> allow distributing typed information (#356) * allow distributing typed information * restore include relax python constraint (#357) relock add Update docs/efficient_run_on_multi_workers.rst Co-authored-by: Keisuke OGAKI <hikingko1@gmail.com> set complete_check_at_run=False * add * add blank line * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow distributing package typed information (https://peps.python.org/pep-0561/)