fix LoggerConfig inconsistency bug #233
Merged
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mski-iksm
requested review from
hirosassa,
Hi-king and
vaaaaanquish
and removed request for
hirosassa and
Hi-king
vaaaaanquish
reviewed
Aug 9, 2021
gokart/build.py
Outdated
| self.logger.setLevel(self.level) | ||
| return self | ||
|
|
||
| def __exit__(self, exception_type, exception_value, traceback): | ||
| logging.disable(self.default_level) | ||
| logging.disable(self.default_level - 10) |
There was a problem hiding this comment.
Does it make sense to be 10? If not, use sys.maxsize to make the meaning clearer.
There was a problem hiding this comment.
@vaaaaanquish
I think it should be 10, because we want to change "disabling logs with level self.default_level and bellow" to "disabling logs with levels bellow self.default_level"
There was a problem hiding this comment.
I see. It seems like a good idea to put it in the comments.
|
Thanks! LGTM |
hirosassa
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gokart.build()has a feature to disable low important logs.However, the implementation has inconsistency,
This is because logging.Logger.setLevel and logging.disable has the following difference.
This PR fix the inconsistency by
disabling any logs with level below the self.level