Add parameter alias to inherits_config_params #193
Merged
+44
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaaaaanquish
requested changes
Apr 14, 2021
test/test_config_params.py
Outdated
| @@ -25,6 +25,12 @@ class Inherited(gokart.TaskOnKart): | |||
| param_b = luigi.Parameter(default='overrided') | |||
|
|
|||
|
|
|||
| @inherits_config_params(ConfigClass, param_config2task={'param_a': 'param_d'}) | |||
There was a problem hiding this comment.
When would you be happy with this feature?
There was a problem hiding this comment.
@vaaaaanquish
This would be useful when ConfigClass and Wrapped class has different parameter name but want to have common value.
There was a problem hiding this comment.
@vaaaaanquish
I've added use case to the docs.
https://github.com/m3dev/gokart/pull/193/files#diff-bd31f137cd4066a176d3de6d9729841a660ed1416d3a26cf9bd0c820211ad8b8R57
Hi-king
reviewed
Apr 18, 2021
gokart/config_params.py
Outdated
| import luigi | ||
|
|
||
| import gokart | ||
|
|
||
|
|
||
| class inherits_config_params: | ||
| def __init__(self, config_class: luigi.Config): | ||
| self.config_class: luigi.Config = config_class | ||
| def __init__(self, config_class: luigi.Config, param_config2task: Optional[Dict[str, str]] = None): |
There was a problem hiding this comment.
@mski-iksm [nits] Plz write docstring about args here :)
There was a problem hiding this comment.
@Hi-king
I've changed param_config2task to parameter_alias. Please review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows to replace parameter name of inherited config Task, when using
@inherits_config_paramsdecorator.Currently, when using
@inherits_config_params, parameter name of inheriting config Task and decorated Task must be same. After this PR, parameter name can be replaced by passing parameter names dictionaryparam_config2taskto@inherits_config_paramsdecorator.Please review!
@hirosassa @vaaaaanquish @e-mon @Hi-king