support Python 3.12 (#325)

* feat: support Python 3.12

* fix: poetry lock

* feat: drop python 3.8

* fix: poetry lock

* fix: upgrade pyproject-flake8 version

* fix: downgrade python version for flake8

pyproject-flake8 doesn't support python 3.12

.github/workflows/format.yml

@@ -16,7 +16,7 @@ jobs:
     - uses: actions/checkout@v3
     - uses: actions/setup-python@v4
       with:
-        python-version: 3.9
+        python-version: 3.11
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip

.github/workflows/test.yml

@@ -12,7 +12,7 @@ jobs:
       max-parallel: 4
       matrix:
         platform: [ubuntu-latest]
-        python-version: ["3.8", "3.9", "3.10", "3.11"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
 
     steps:
     - uses: actions/checkout@v3

gokart/pandas_type_config.py

@@ -49,5 +49,5 @@ def __init__(self, *args, **kwargs) -> None:
         }
 
     def check(self, obj, task_namespace: str):
-        if type(obj) == pd.DataFrame and task_namespace in self._map:
+        if isinstance(obj, pd.DataFrame) and task_namespace in self._map:
             self._map[task_namespace].check(obj)

gokart/task.py

@@ -346,7 +346,7 @@ def get_info(self, only_significant=False):
         params = dict(self.get_params())
         for param_name, param_value in self.param_kwargs.items():
             if (not only_significant) or params[param_name].significant:
-                if type(params[param_name]) == gokart.TaskInstanceParameter:
+                if isinstance(params[param_name], gokart.TaskInstanceParameter):
                     params_str[param_name] = type(param_value).__name__ + '-' + param_value.make_unique_id()
                 else:
                     params_str[param_name] = params[param_name].serialize(param_value)
@@ -452,7 +452,7 @@ def _get_module_versions(self) -> str:
         for x in set([x.split('.')[0] for x in globals().keys() if isinstance(x, types.ModuleType) and '_' not in x]):
             module = import_module(x)
             if '__version__' in dir(module):
-                if type(module.__version__) == str:
+                if isinstance(module.__version__, str):
                     version = module.__version__.split(" ")[0]
                 else:
                     version = '.'.join([str(v) for v in module.__version__])

gokart/tree/task_info_formatter.py

@@ -72,7 +72,7 @@ def make_task_info_tree(task: TaskOnKart, ignore_task_names: Optional[List[str]]
 
     params = task.get_info(only_significant=True)
     processing_time = task.get_processing_time()
-    if type(processing_time) == float:
+    if isinstance(processing_time, float):
         processing_time = str(processing_time) + 's'
     is_complete = ('COMPLETE' if is_task_complete else 'PENDING')
     task_log = dict(task.get_task_log())

pyproject.toml

@@ -16,7 +16,7 @@ style = "pep440"
 pattern = "^(?P<base>\\d+\\.\\d+\\.\\d+)"
 
 [tool.poetry.dependencies]
-python = ">=3.8,<3.12"
+python = ">=3.9,<3.13"
 luigi = "*"
 boto3 = "*"
 slack-sdk = "^3"
@@ -32,7 +32,7 @@ redis = "*"
 matplotlib = "*"
 
 [tool.poetry.group.dev.dependencies]
-pyproject-flake8 = "5.0.4"
+pyproject-flake8 = "^6.1.0"
 tox = "*"
 moto = "*"
 testfixtures = "*"

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = py{38,39,310,311},yapf,isort,flake8,mypy
+envlist = py{39,310,311,312},yapf,isort,flake8,mypy
 isolated_build = true
 
 [testenv]
@@ -29,7 +29,7 @@ commands = mypy gokart test {posargs}
 
 [gh-actions]
 python =
-    3.8: py38
     3.9: py39
     3.10: py310
     3.11: py311
+    3.12: py312