Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker] Mysql backup + PHPMyAdmin service #4

Closed
wants to merge 3 commits into from

Conversation

mfdeveloper
Copy link

@mfdeveloper mfdeveloper commented Apr 24, 2018

I've added docker compose improvements with more features:

  • Added new service phpmyadmin to manager your mysql database

  • Create a new Dockerfile for wp-cli to execute wordpress database actions. For this, is required share the wp-config.php file among services, and containers S.O user permissions. See this issue: docker-library/wordpress#256

  • Added new volumes (e.g wp-src to point to wordpress source code)

  • Created a backup folder and a mysql.sh script to generate/restore backup files

    PS: I think that is better a node.js implementation for this (cross-platform support), maybe using like a totally separated repo and npm package. But, that request more time, and the shell script added in this PR solves by now!

  • Updated README.md with docker backup functions

@mfdeveloper mfdeveloper force-pushed the docker-improvements branch 3 times, most recently from 238ed35 to bf01b99 Compare July 5, 2018 03:03
@lyzs90
Copy link
Owner

lyzs90 commented Jul 18, 2018

Thanks for this pr. I'm not sure if we should include database management in this project because the scope was intended to be purely for the view layer, just like other wordpress themes. The docker setup you see is just to facilitate development

I'll close and tag this PR as tutorial so others who are keen to use phpmyadmin can find it

@lyzs90 lyzs90 added the tutorial setting up phpmyadmin label Jul 19, 2018
@lyzs90 lyzs90 closed this Jul 19, 2018
@mfdeveloper
Copy link
Author

mfdeveloper commented Jul 23, 2018

Hi @lyzs90 ! Thank you for your feedback. I understand your concerns...so, maybe will be better keep a completelly separated repo with vuewp theme (e.g. like a wpackagist composer package) and other repo containing the wp docker and compose files. The tutorial tag is a good "start point", but I think that separated repos can be more concise and more flexible for accept PR's. Moreover, you can add a CONTRIBUTING guide with details about NOT create PR's for here with docker improvements.

I'm using wp docker environment approach + vue themes, and separated repos seems a better strategy for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tutorial setting up phpmyadmin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants