Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@mui/lab to @mui/x-date-pickers transition #84

Merged

Conversation

PetroSilenius
Copy link
Contributor

Separates just the package transition from #82

When clearing the value of a Timepicker it throws an error, "Cannot read properties of null (reading 'hour')"
Importing Timepicker and LocalizationProvider from "@mui/x-date-pickers" instead of "@mui/lab" fixed the problem.
This change has to be done at latest in July since "@mui/lab" will stop exporting Date and Timepickers in versions after July 2022.

Tested by locally linking to a project and things seemed to work in the same way with the @mui/lab components

Breaking changes
LocalizationProvider's prop locale is deprecated and replaced by adapterLocale

Copy link
Contributor

@kacperkosinski kacperkosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😃

Copy link
Contributor

@mikael-jarvinen mikael-jarvinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@PetroSilenius
Copy link
Contributor Author

We discussed this with @mikael-jarvinen and decided that we'll push this in the next release to fix the issue and in a separate PR fix the type and ref issues

@PetroSilenius PetroSilenius merged commit 6e94e1f into lyytioy:next Jun 13, 2022
@PetroSilenius PetroSilenius deleted the lab-x-date-pickers-transition branch June 13, 2022 09:52
@PetroSilenius PetroSilenius mentioned this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants