Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re export radiogroup component #77

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Re export radiogroup component #77

merged 3 commits into from
Jun 9, 2022

Conversation

kacperkosinski
Copy link
Contributor

Re-export RadioGroup component from MUI

@kacperkosinski kacperkosinski requested a review from a team as a code owner June 8, 2022 14:12
grzegorz-bach
grzegorz-bach suggested changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@grzegorz-bach grzegorz-bach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One thing I would suggest to do is wrap the component withforwardRef to avoid uneccessary ref errors in the future 🙂

@kacperkosinski
Copy link
Contributor Author

Looks great. One thing I would suggest to do is wrap the component withforwardRef to avoid uneccessary ref errors in the future 🙂

Good point! Fixed

@kacperkosinski kacperkosinski merged commit 1316653 into lyytioy:next Jun 9, 2022
@kacperkosinski kacperkosinski mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzegorz-bach grzegorz-bach grzegorz-bach approved these changes

@PetroSilenius PetroSilenius PetroSilenius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kacperkosinski @grzegorz-bach @PetroSilenius