Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme for headers names #589

Merged
merged 1 commit into from
Mar 29, 2016
Merged

Update readme for headers names #589

merged 1 commit into from
Mar 29, 2016

Conversation

ash1day
Copy link
Contributor

@ash1day ash1day commented Mar 29, 2016

Ref: #569

@booleanbetrayal
Copy link
Collaborator

thanks @y4ashida !

@booleanbetrayal booleanbetrayal merged commit 1cf0a81 into lynndylanhurley:master Mar 29, 2016
@ash1day
Copy link
Contributor Author

ash1day commented Mar 31, 2016

@booleanbetrayal
I realized this commit isn't good, because config/applicaiton.rb is loaded before config/initializers/devise_token_auth.rb.
So, if you change headers names in config/initializers/devise_token_auth.rb, the changes aren't reflected in config/applicaiton.rb.

Moreover, DeviseTokenAuth.headers_names isn't defined in some cases. #591

Sorry to trouble you. I think this commit should be reverted.

@ash1day ash1day mentioned this pull request Mar 31, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ash1day @booleanbetrayal