Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devise trackable module not working #62

Closed
smarquez1 opened this issue Nov 7, 2014 · 10 comments
Closed

Devise trackable module not working #62

smarquez1 opened this issue Nov 7, 2014 · 10 comments

Comments

@smarquez1
Copy link

Columns:
sign_in_count, current_sign_in_at, last_sign_in_at, current_sign_in_ip, last_sign_in_ip

are not being updating after user logs in.

@booleanbetrayal
Copy link
Collaborator

FWIW - initial glance seems that this is working on my end:

back_royal_development=# select sign_in_count, last_sign_in_at from users where id=1;
 sign_in_count |      last_sign_in_at       
---------------+----------------------------
           118 | 2014-11-07 17:09:47.986049
(1 row)

and with subsequent login ...

back_royal_development=# select sign_in_count, last_sign_in_at from users where id=1;
 sign_in_count |      last_sign_in_at       
---------------+----------------------------
           119 | 2014-11-07 17:11:24.351536
(1 row)

@smarquez1
Copy link
Author

Thanks @booleanbetrayal , must be an issue with my configuration. Are you using the latest devise/ng-token auth betas?

@markusklooth
Copy link

This also doesn't work for me. I'm using 0.1.29.beta7.

@lynndylanhurley
Copy link
Owner

Hey guys, I think I just fixed this recently. Can you all try version 0.1.30.beta3 to confirm?

If this solves the problem then I'll push an official release.

@smarquez1
Copy link
Author

@lynndylanhurley - I'm already using devise_token_auth, '0.1.30.beta3' and "ng-token-auth": "~0.0.24-beta6"

@markusklooth
Copy link

Just upgraded to devise_token_auth 0.1.30.beta3 and it doesn't work. the following attributes are still empty:
remember_created_at: nil, sign_in_count: 0, current_sign_in_at: nil, last_sign_in_at: nil, current_sign_in_ip: nil, last_sign_in_ip: nil

@booleanbetrayal
Copy link
Collaborator

sorry @smarquez1 - I'm on devise_token_auth 0.1.30.beta3 and ng-token-auth 0.0.24-beta1. I had migrated our Rails project from a vanilla Devise, cookie-based authentication scheme .. but I can't imagine that'd make any difference.

@mvoloz
Copy link

mvoloz commented Nov 7, 2014

same for me using devise_token_auth 0.1.30.beta3 with ng-token-auth 0.0.24-beta6

@lynndylanhurley
Copy link
Owner

Ok thanks guys! Looks like I didn't have good enough coverage on this. I'll try to push a fix out later today.

@lynndylanhurley
Copy link
Owner

It looks like trackable was set for email sign-in, but not OAuth sign-in. Version 0.1.30.beta5 should contain the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants