Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add legacyhandler back (deleted it in 766 oops) #769

Merged
merged 3 commits into from
Aug 13, 2024
Merged

add legacyhandler back (deleted it in 766 oops) #769

merged 3 commits into from
Aug 13, 2024

Conversation

smonero
Copy link
Contributor

@smonero smonero commented Aug 13, 2024

In https://github.com/lyft/atlantis/pull/766/files#top I accidently deleted the legacyHandler functionality. It worked in staging so I assumed it was fine, but apparently not, since some people had problems where the status was reported. This should fix that.

Just to clarify why it is ok to delete the other parts and not the legacyHandler:

  • The legacyHandler actually calls the UpdateCombinedCount func that is needed for github updates
  • The other parts, like the comment handler and error handler only forwarded things to sns, which is why we don't need them

@smonero smonero changed the title actually still need legacyhandler add legacyhandler back (deleted it in 766 oops) Aug 13, 2024
@smonero smonero merged commit ee0083c into main Aug 13, 2024
3 checks passed
@smonero smonero deleted the handler branch August 13, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants