Support retries on first commit #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecutalo
reviewed
Jul 25, 2023
Comment on lines
-204
to
-215
| v := workflow.GetVersion(ctx, AddNotifierVersion, workflow.DefaultVersion, workflow.Version(2)) | ||
|
|
||
| var notifierPeriod time.Duration | ||
| if v == workflow.Version(1) { | ||
| notifierPeriod = r.NotifierPeriod(ctx, QueueStatusNotifierHourPST) | ||
| } else if v == workflow.Version(2) { | ||
| notifierPeriod = r.NotifierPeriod(ctx, QueueStatusNotifierHourUTC) | ||
| } | ||
|
|
||
| if v > workflow.DefaultVersion { | ||
| s.AddTimeout(ctx, notifierPeriod, notifyTimerFunc) | ||
| } |
There was a problem hiding this comment.
When deciding to remove this versions, do we first check if their are any running workflows that are still active on the older version, in this case version 1?
There was a problem hiding this comment.
yes that's correct
mikecutalo
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally required retries to only be allowed on the same revision as the last attempted deploy to prevent accidental reverts in history. However, there is an edge case where the first deployment on a root needs a retry. When it's the first deployment, the commit direction will always default to
DirectionAheadinstead ofDirectionIdenticalso we need to handle that scenario separately.This change is technically a non-deterministic change (very unlikely to occur, as it's a rare scenario) so I've protected the rollout with versioning. While doing this, I also went ahead and cleaned up old versions in the Deploy workflow that are no longer relevant.