Use global cfg installation id for temporal worker github activities #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samrabelachew
changed the title
samrabelachew
added a commit
that referenced
this pull request
Jul 14, 2023
Two changes here: 1. Inject installation ID defining a separate GH app for gateway and temporal servers (we will [eventually](#711) reconfigure code to use these installation ids over the ones passed in from the webhook event) 2. Set up new github ratelimit stats publisher in gateway and temporal servers that use these app installations. This already needed to be migrated over to the new workers anyways, but also can serve as an initial test of the new ids without having to impact existing code.
samrabelachew
added a commit
that referenced
this pull request
Jul 19, 2023
This is just temporary for a cleaner rollout. Originally merged this change to test in staging, but ideally, all instances of using the new `TemporalAppInstallationID` config should be rolled out together in #711
added 2 commits
July 19, 2023 08:18
mikecutalo
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's pass the new installation id configuration throughout all use cases of the GH id in the temporal worker.