Pass installation id to pr revision activities (#716)

Missed this workflow when migrating over to static ids in previous PR.
lyft · Jul 20, 2023 · fcd0d39 · fcd0d39
1 parent 54778ce
commit fcd0d39
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/server/neptune/lyft/activities/github.go b/server/neptune/lyft/activities/github.go
@@ -13,7 +13,8 @@ import (
 )
 
 type Github struct {
-	ClientCreator githubapp.ClientCreator
+	ClientCreator  githubapp.ClientCreator
+	InstallationID int64
 }
 
 type ListPRsRequest struct {
@@ -29,7 +30,7 @@ type ListPRsResponse struct {
 
 func (a *Github) GithubListPRs(ctx context.Context, request ListPRsRequest) (ListPRsResponse, error) {
 	prs, err := a.listPullRequests(
-		ctx, request.Repo.Credentials.InstallationToken,
+		ctx, a.InstallationID,
 		request.Repo.Owner,
 		request.Repo.Name,
 		request.Repo.DefaultBranch,
@@ -65,7 +66,7 @@ type ListModifiedFilesResponse struct {
 
 func (a *Github) GithubListModifiedFiles(ctx context.Context, request ListModifiedFilesRequest) (ListModifiedFilesResponse, error) {
 	files, err := a.listModifiedFiles(
-		ctx, request.Repo.Credentials.InstallationToken,
+		ctx, a.InstallationID,
 		request.Repo.Owner,
 		request.Repo.Name,
 		request.PullRequest.Number,

diff --git a/server/neptune/temporalworker/server.go b/server/neptune/temporalworker/server.go
@@ -213,7 +213,8 @@ func NewServer(config *config.Config) (*Server, error) {
 	}
 
 	prRevisionGithubActivities := &lyftActivities.Github{
-		ClientCreator: clientCreator,
+		ClientCreator:  clientCreator,
+		InstallationID: config.GithubCfg.TemporalAppInstallationID,
 	}
 
 	cronScheduler := internalSync.NewCronScheduler(config.CtxLogger)