Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework monitors processing for desktop manager. #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LStranger
Copy link
Member

It should not enumerate them but remember plugs instead and associate config with them.
When monitor is getting plugged off then plugged on, it will get remembered config back.

This change is made instead of #3 to handle it more correctly. Some fixes from #3 should be pulled separately though.

It should not enumerate them but remember plugs instead and associate config with them.
When monitor is getting plugged off then plugged on, it will get remembered config back.
@wb9688
Copy link

wb9688 commented Mar 16, 2021

It seems to be broken now: when I add a monitor, it doesn't come up there, while when I remove a monitor, it gets stuck in a loop in renumber_monitors.

@@ -2,7 +2,7 @@
* app-config.c
*
* Copyright 2010 PCMan <pcman.tw@gmail.com>
* Copyright 2012-2014 Andriy Grytsenko (LStranger) <andrej@rep.kiev.ua>
* Copyright 2012-2021 Andriy Grytsenko (LStranger) <andrej@rep.kiev.ua>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I think you want 2012-2014, 2021 instead, because 2012-2021 would mean you've also touched the code in 2015, 2016, 2017, 2018, 2019, and 2020.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use simple range, anyways I did it everywhere before so it's too late for such details now. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants