Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoom by drag feature to interaction hook #227

Merged
merged 5 commits into from
Mar 23, 2022
Merged

Conversation

deminoth
Copy link
Member

@deminoth deminoth commented Mar 21, 2022

📝 Description

마우스 드래그 동작으로 기존에 지원하던 이동, 윈도우 조절 외에 줌 인 / 아웃을 추가합니다.
드래그를 통한 줌 방식은 애플리케이션마다 다르나, 여기서는 INSIGHT View에서 사용할 우측으로 드래그하면 줌 인, 좌측으로 드래그하면 줌 아웃을 구현했습니다.
줌 기준점은 영상 중앙이 아닌 마우스 드래그 시작점이며, 이 기능은 휠을 통한 줌에도 차후 적용할 예정입니다.

스크린샷 2022-03-21 오후 3 48 03

✔️ PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Chore (non-breaking change which does not affect codebase; Build related changes, version modification, etc.)
  • CI related changes
  • Test Case
  • Performance optimization
  • Site/documentation update
  • Other... Please describe:

🎯 Current behavior

{ setInteraction } = useInteraction()primaryDrag, secondaryDrag'pan', 'adjust' 만 사용 가능

🚀 New behavior

'zoom' 추가

💣 Is this a breaking change?

  • Yes
  • No

기존에 뷰어에서 익스포트하던 DragEvent 타입의 명명이 혼동을 가져올 수 있어 DragAction으로 변경하였습니다. 기존 타입은 deprecated 표시하였으며 여전히 사용 가능합니다.

@deminoth deminoth added the enhancement New feature or request label Mar 21, 2022
@deminoth deminoth self-assigned this Mar 21, 2022
@github-actions
Copy link

github-actions bot commented Mar 21, 2022

@deminoth deminoth changed the base branch from master to develop March 21, 2022 07:35
Copy link
Collaborator

@LTakhyunKim LTakhyunKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zoom 기능 동작 확인 했습니다~

@deminoth deminoth merged commit 5f39063 into develop Mar 23, 2022
@deminoth deminoth deleted the feature/drag-zoom branch March 23, 2022 06:45
@deminoth deminoth mentioned this pull request Mar 25, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants