Skip to content

Commit

Permalink
[dlpack] Fix NDK 27+ CMake error (#266)
Browse files Browse the repository at this point in the history
* [dlpack] fix NDK 27+ build
* require CMake 3.22+
  • Loading branch information
luncliff committed Sep 16, 2024
1 parent 1ba1777 commit 6e7e653
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 3 deletions.
11 changes: 9 additions & 2 deletions ports/dlpack/fix-cmake.patch
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
index ea113e1..ed9671a 100644
index ea113e1..105244f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -8,7 +8,7 @@ cmake_minimum_required(VERSION 3.2 FATAL_ERROR)
@@ -2,13 +2,13 @@
# Set minimum version of CMake. Since command 'project' use
# VERSION sub-option we need at least 3.0.
# Note: If you use 2.6 or 2.4, God kills a kitten. Seriously.
-cmake_minimum_required(VERSION 3.2 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.22 FATAL_ERROR)

####
# Set variables:
# * PROJECT_NAME
# * PROJECT_VERSION
Expand Down
1 change: 1 addition & 0 deletions ports/dlpack/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "dlpack",
"version": "1.0",
"port-version": 1,
"description": "common in-memory tensor structure",
"homepage": "https://github.com/dmlc/dlpack",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"dlpack": {
"baseline": "1.0",
"port-version": 0
"port-version": 1
},
"eigen3": {
"baseline": "2024-08-01",
Expand Down
5 changes: 5 additions & 0 deletions versions/d-/dlpack.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "f9ad85c812127a21c0f88cf0c9267e08f85cd0c9",
"version": "1.0",
"port-version": 1
},
{
"git-tree": "deca608a2d8a5edb98345ecd50e2f174dea6f9ae",
"version": "1.0",
Expand Down

0 comments on commit 6e7e653

Please sign in to comment.