Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RD-13495 opentelemetry python contrib version #870

Merged
merged 16 commits into from
Sep 12, 2024
Merged

RD-13495 opentelemetry python contrib version #870

merged 16 commits into from
Sep 12, 2024

Conversation

eugene-lumigo
Copy link
Collaborator

@eugene-lumigo eugene-lumigo commented Aug 28, 2024 •
edited
Loading

  • Version 1.26.0/0.47b0

@eugene-lumigo eugene-lumigo changed the title RD 13495 opentelemetry python contrib version RD-13495 opentelemetry python contrib version Aug 28, 2024
Eugene Orlovsky added 5 commits August 28, 2024 14:41
sagivoululumigo
sagivoululumigo requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@sagivoululumigo sagivoululumigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the readme for supported runtimes.

Note: Don't manually edit the supported versions table, I think the automated version tester should take care of that

GuyMoses
GuyMoses requested changes Sep 1, 2024
View reviewed changes
Copy link
Collaborator

@GuyMoses GuyMoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the README.md file please state exactly when we deprecated python3.7 and state exactly the last known version to be supporting python3.7

sagivoululumigo
sagivoululumigo reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@sagivoululumigo sagivoululumigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, left small comments

eugene-lumigo
eugene-lumigo commented Sep 11, 2024
View reviewed changes
Copy link
Collaborator Author

@eugene-lumigo eugene-lumigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Submitted,

README.md Show resolved Hide resolved
src/lumigo_opentelemetry/__init__.py Outdated Show resolved Hide resolved
src/test/unit/test_tracer.py Outdated Show resolved Hide resolved
.github/workflows/version-testing.yml Show resolved Hide resolved
src/lumigo_opentelemetry/__init__.py Outdated Show resolved Hide resolved
src/lumigo_opentelemetry/instrumentations/fastapi/parsers/__init__.py Show resolved Hide resolved
.github/workflows/version-testing.yml Show resolved Hide resolved
sagivoululumigo
sagivoululumigo approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@sagivoululumigo sagivoululumigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@eugene-lumigo eugene-lumigo enabled auto-merge (squash) September 11, 2024 13:20
@eugene-lumigo eugene-lumigo merged commit e48843f into main Sep 12, 2024
84 of 85 checks passed
@eugene-lumigo eugene-lumigo deleted the RD-13495-opentelemetry-python-contrib-version branch September 12, 2024 07:23
GuyMoses pushed a commit that referenced this pull request Sep 12, 2024
1.0.155 → 1.0.156. Changes: e48843f RD-13495 opentelemetry python con…
1691ea3 
…trib version (#870)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuyMoses GuyMoses GuyMoses approved these changes

@sagivoululumigo sagivoululumigo sagivoululumigo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eugene-lumigo @GuyMoses @sagivoululumigo