Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uploader): add component #208

Merged
merged 6 commits into from
Nov 6, 2019
Merged

feat(uploader): add component #208

merged 6 commits into from
Nov 6, 2019

Conversation

matmkian
Copy link
Collaborator

General summary

Add uploader component.

Screenshots

Capture d’écran 2019-10-25 à 14 26 28

@gcornut
Copy link
Member

gcornut commented Nov 5, 2019

@matmkian I've done the React part. Here is what I added which is not in angular:

  • Default size is set to XL since the component does not look good with sizes under that
  • Size range is limited to XL and XXL
  • The aspect ratio will be overriden to "square" if the variant is "circle" to prevent weird oval shape

Let me know if you are against any of theses. I can implement them in Angular too if you want

@matmkian
Copy link
Collaborator Author

matmkian commented Nov 5, 2019

@gcornut, you're so perfect! If you can implement those changes in the Angularjs version that would be perfect!

@FlorentDinet
Copy link
Contributor

I see a lot of differences with the mockups https://app.zeplin.io/project/5beed1207b5f913ebc61d14e/dashboard?seid=5dadbbbc7ef2d22c514c286b
is this wanted ?

Also AspectRatio.original seems broken (no background and somewhat no bounding box)
Capture d’écran 2019-11-06 à 16 38 33
Capture d’écran 2019-11-06 à 16 38 58

@matmkian
Copy link
Collaborator Author

matmkian commented Nov 6, 2019

Need to talk about that @FlorentDinet , only did https://app.zeplin.io/project/5beed1207b5f913ebc61d14e/screen/5dbfe0c71ad43e22ffd2e906 and no original aspect ratio

@FlorentDinet
Copy link
Contributor

Ok to discuss, it's a nice start let's merge, and improve later

@pidupuis pidupuis merged commit fc573c5 into master Nov 6, 2019
@pidupuis pidupuis deleted the feat/uploader branch November 6, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants