Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Switch): improve onChange types #4286

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix(Switch): improve onChange types #4286

merged 1 commit into from
Aug 21, 2024

Conversation

zettca
Copy link
Member

@zettca zettca commented Aug 21, 2024 •
edited
Loading

Narrow down onChange to be of HTMLInputElement, so that event can be used without casting

@zettca zettca requested a review from a team as a code owner August 21, 2024 08:57
@zettca zettca requested review from plagoa and VGervasio and removed request for a team August 21, 2024 08:57
@github-actions github-actions bot temporarily deployed to uikit/pr-4286 August 21, 2024 08:59 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4286 August 21, 2024 09:00 Destroyed
@zettca zettca merged commit 25e4544 into master Aug 21, 2024
13 checks passed
@zettca zettca deleted the fix/stuff branch August 21, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MEsteves22 MEsteves22 MEsteves22 approved these changes

@plagoa plagoa Awaiting requested review from plagoa plagoa is a code owner automatically assigned from lumada-design/imperial

@VGervasio VGervasio Awaiting requested review from VGervasio VGervasio is a code owner automatically assigned from lumada-design/imperial

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zettca @MEsteves22