Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): default maxHeight with multiSelect/showSearch #4275

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

zettca
Copy link
Member

@zettca zettca commented Aug 14, 2024

  • Fix HvDropdown's maxHeight when using with multiSelect & showSearch
    • moved to CSS vars in style, but kept the (hard-coded) height calculation logic
    • height passed to style as it's a user-defined prop
  • Improve Docs/Test
    • merge samples related to height & search, and test it with Chromatic
    • inline Main story so changed args reflect on the source code (Storybook's generated code is good enough)
    • move Empty sample to Variants so it's also tested in Chromatic

Note

Also changes Visual Tests / Chromatic Checks to always ✅ in PRs.
Chromatic's own Checks will handle the rest

GitHub deployments are flaky again 🤷

@zettca zettca requested a review from a team as a code owner August 14, 2024 14:27
@zettca zettca requested review from plagoa and MEsteves22 and removed request for a team August 14, 2024 14:27
@zettca zettca changed the title fix(Dropdown): maxHeight with multiSelect & showSearch fix(Dropdown): default maxHeight with multiSelect/showSearch Aug 14, 2024
@github-actions github-actions bot temporarily deployed to uikit/pr-4275 August 14, 2024 14:29 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4275 August 14, 2024 14:30 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4275 August 14, 2024 14:48 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4275 August 14, 2024 14:48 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4275 August 14, 2024 15:39 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4275 August 14, 2024 15:39 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4275 August 14, 2024 15:54 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4275 August 14, 2024 15:55 Destroyed
merge height+search related samples & test with Chromatic
@github-actions github-actions bot temporarily deployed to uikit/pr-4275 August 14, 2024 16:03 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4275 August 14, 2024 16:03 Destroyed
@zettca zettca force-pushed the fix/stuffs branch 2 times, most recently from d924116 to 446ce00 Compare August 14, 2024 16:06
@github-actions github-actions bot temporarily deployed to uikit/pr-4275 August 14, 2024 16:09 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4275 August 14, 2024 16:10 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4275 August 14, 2024 16:28 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4275 August 14, 2024 16:29 Destroyed
@MEsteves22 MEsteves22 merged commit 0c37a4a into master Aug 16, 2024
12 of 13 checks passed
@MEsteves22 MEsteves22 deleted the fix/stuffs branch August 16, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants