fix(Dropdown): default maxHeight
with multiSelect
/showSearch
#4275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HvDropdown
'smaxHeight
when using withmultiSelect
&showSearch
style
, but kept the (hard-coded) height calculation logicheight
passed tostyle
as it's a user-defined propMain
story so changed args reflect on the source code (Storybook's generated code is good enough)Empty
sample toVariants
so it's also tested in ChromaticNote
Also changes
Visual Tests / Chromatic
Checks to always ✅ in PRs.Chromatic's own Checks will handle the rest
GitHub deployments are flaky again 🤷