Support importing totalist/sync from es modules #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when I'm trying to import `totalist/sync` from es module in node I get this error ``` Error [ERR_UNSUPPORTED_DIR_IMPORT]: Directory import '.../node_modules/totalist/sync' is not supported resolving ES modules imported from my-script.js Did you mean to import totalist/sync/index.js? ``` Exports field will help to fix this.
lukeed
reviewed
Jan 17, 2022
|
Do you want to do something else before release? |
|
Released as 3.0.0 now – i wasnt by a computer yesterday when I merged :) |
|
Thanks! |
|
sirv@2.0.2 is now released too btw, which is probably why/where you saw this error |
|
Ah, no. I used totalist in our build scripts 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when I'm trying to import
totalist/syncfromes module in node I get this error
Exports field will help to fix this.