fixing a bug where dragging.style.display was not restored on dragend (…

…#777)
lukasoppermann · Jun 29, 2021 · bbc209b · bbc209b
1 parent 0f860ff
commit bbc209b
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/html5sortable.ts b/src/html5sortable.ts
@@ -425,7 +425,10 @@ export default function sortable (sortableElements, options: configuration|objec
       if (dragging.getAttribute('aria-copied') === 'true' && data(dragging, 'dropped') !== 'true') {
         dragging.remove()
       }
-
+      if (dragging.oldDisplay !== undefined) {
+        dragging.style.display = dragging.oldDisplay
+        delete dragging.oldDisplay
+      }
       const visiblePlaceholder = Array.from(stores.values()).map(data => data.placeholder)
         .filter(placeholder => placeholder instanceof HTMLElement)
         .filter(isInDom)[0]
@@ -475,8 +478,10 @@ export default function sortable (sortableElements, options: configuration|objec
       if (visiblePlaceholder) {
         visiblePlaceholder.replaceWith(dragging)
         // to avoid flickering restoring element display immediately after replacing placeholder
-        dragging.style.display = dragging.oldDisplay
-        delete dragging.oldDisplay
+        if (dragging.oldDisplay !== undefined) {
+          dragging.style.display = dragging.oldDisplay
+          delete dragging.oldDisplay
+        }
       } else {
         // set the dropped value to 'false' to delete copied dragging at the time of 'dragend'
         data(dragging, 'dropped', 'false')