-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chemovesicle #161
Open
jeremie-mb
wants to merge
91
commits into
ludwig-cf:develop
Choose a base branch
from
jeremie-mb:chemovesicle
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chemovesicle #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces 1 alert when merging efb26a8 into 19093eb - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging eb6ff0c into 19093eb - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging eb6ff0c into 8bb71d5 - view on LGTM.com new alerts:
|
Phi-subgrid interaction, vesicles and 2,3 and 4-body potentials now work much better.
Corresponding attribute in colloid.h (localmobility) Corresponding function in subgrid.c
==> Space dependant mobility - can now be turned on/off in input file - defaults to physics mobility when turned off - map created around each colloid, assigning colloid->s.localmobility in a region of size colloid->s.localrange around each colloid ==> The force that PHI generates on the colloid due to the PHI-SUBGRID interaction is now calculated using centered difference instead of analytic gradient of U. This is done in interaction.c. Force balance is now enforced exactly. ==> field_t * subgrid_flux has new name "subgrid_potential" ==> Added communication between processes to allow center of mass update of the central subgrid particle. This is done in colloid_sums.c and subgrid.c. ==> Visualization of mobility_map slices in ludwig.c (temporary but I need to commit ludwig.c) ==> Duplicates of bond_harmonic structures to allow for 3 different springs, each with their own k and l0.
- utility to create vesicle input file
Added subgrid_phi_production Central now updated like all the other (no centerofmass update) Still the possibility to change this with broadcasting of dr Added ishole attribute
…s in write_hexasphere
…ticles with symmetric_ll
…instead of just rmax < wcell
…ixed important bug in subgrid.c which broke conservation of phi+psi
… fluid when using external gradient, added psi<->phi with conservation
…at they can be used with or without hydro
…nt when using psi_gradmu_outside_vesicle_only or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New potential for subgrid particles