-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symmetric oft #149
Open
jeremie-mb
wants to merge
51
commits into
ludwig-cf:master
Choose a base branch
from
jeremie-mb:symmetric_oft
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Symmetric oft #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MMETRIC_OFT) Initialisation of the temperature field Changes in existing files: - ludwig.c (added the initialisation of temperature field and of symmetric_oft free energy) - physics.[ch] (added lambda and T0 set and get functions) - gradient_3d_27pt_solid.[ch] (added _oft functions which use symmetric_oft structure instead of symmetric structure) - gradient_rt.c (added 3d_27pt_solid_oft key which points to the correct structure in gradient_rd_27pt_solid.[ch]) - phi_force_stress.c (switched the computation of the stress to the non-vectorised version) - symmetric_oft.c (Stress now computes both thermal and chemical components) New files: - field_temperature_init.c - field_temperature_init.h - field_temperature_init_rt.c - field_temperature_init_rt.h - symmetric_oft_rt.c - symmetric_oft_rt.h
==> Temperature now evolves according to the heat equation. The functions were adapted from phi_cahn_hilliard.[ch] and so are based on a Cahn-Hilliard template, they are found in heat_equation.[ch] ==> Temperature undergoes the same treatment as phi in the main code regarding halos. ==> Temperature can be output (in BINARY only) Smaller changes/notes: - Added freq_temperature - Added drop intialisation - Added stats for temperature - No noise for temperature yet - Added timer for temperature Reference input file can be found in ludwig/T
This pull request introduces 1 alert when merging 4ebbe3e into 8fb2392 - view on LGTM.com new alerts:
|
-> Colloid temperature can be set -> Temperature boundary conditions is working -> test and reference input is in ./tests/temperature
This pull request introduces 1 alert when merging c7cbf1e into 8fb2392 - view on LGTM.com new alerts:
|
…bl, the contributions from the thermodynamic and hydrodynamic sector to the total force
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 of temperature implementation.
Added symmetric_aot.[ch] and respective keyword in free_energy.h
Computation of stress is at very early stage and will need to be modified in the future.