Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add standalone example for angular #2383

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

hiepxanh
Copy link
Contributor

add standalone example for angular since it different with current behavior

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

I'm using Lucide with Angular and really love it. I'm using Angular 18 and this update should help standalone user understand how to use it for new standard

Before Submitting

@github-actions github-actions bot added 📖 documentation Improvements or additions to documentation 🌍 site Has to do something with the Lucide website labels Aug 18, 2024
docs/guide/packages/lucide-angular.md Outdated Show resolved Hide resolved
docs/guide/packages/lucide-angular.md Outdated Show resolved Hide resolved
docs/guide/packages/lucide-angular.md Outdated Show resolved Hide resolved
docs/guide/packages/lucide-angular.md Outdated Show resolved Hide resolved
@hiepxanh
Copy link
Contributor Author

@karsa-mistmere Hi Karsa, I squash new commit follow your suggestion. Please review this one

@karsa-mistmere karsa-mistmere merged commit e391973 into lucide-icons:main Aug 21, 2024
2 checks passed
@karsa-mistmere
Copy link
Member

@karsa-mistmere Hi Karsa, I squash new commit follow your suggestion. Please review this one

Hi @hiepxanh,

Thanks for the work, I've merged it.

p.s. In the future please do not force push, squash merge is on by default.

@hiepxanh
Copy link
Contributor Author

It my pleasure to contributing.
That auto squash really amazing, thank for your note. Last time I was blame by forgot to squash 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation 🌍 site Has to do something with the Lucide website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants