Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patched for tensorflow 1.11 #32

Merged
merged 2 commits into from
Oct 19, 2018
Merged

Patched for tensorflow 1.11 #32

merged 2 commits into from
Oct 19, 2018

Conversation

ferrarodav
Copy link
Contributor

Hi,

I tried to use the plugin with the last versions of tensorflow (1.11) and jupyter but it would give an error.
I've noticed that it wasn't recognizing the 1.11 version and it was still using the old api while creating the tensorboard app. I've fixed the problem and tested it.

Davide

In tensorflow 1.11 tensorflow.default doesn't have the PLUGIN_LOADERS attribute, but the _PLUGINS one.
Moreover, the program.TensorBoard class constructor can take the default arguments correctly if they're not passed, this avoids the need to make another if branch for the 1.11 version.
Without argparse would throw "unrecognized arguments:"
@lspvic lspvic merged commit b6889d3 into lspvic:master Oct 19, 2018
@lspvic
Copy link
Owner

lspvic commented Oct 19, 2018

Thanks very much for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants