Fix Rows are not present when job not completed yet.
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lquerel
requested changes
Feb 15, 2023
src/job.rs
Outdated
| max_results: page_size, | ||
| location: Some(location.to_string()), | ||
| ..Default::default() | ||
| }, | ||
| ) | ||
| .await?; | ||
|
|
||
| // Waiting for completed the job. | ||
| if !qr.job_complete.unwrap_or(false) { | ||
| tokio::time::sleep(tokio::time::Duration::from_secs(1)).await; |
There was a problem hiding this comment.
It's probably best to reduce this a bit, as it will add a second of latency even for small to medium sized jobs. I don't know if BigQuery provides any guidance on this, but I would suggest something like 200ms.
There was a problem hiding this comment.
Thank you for review. Change to 200ms.
I think best solution is specify delay by user but it makes breaking changes.
|
I'm not sure when I will be able to push a new version on crates.io. I'm on vacation for the week with an intermittent internet connection. I will do my best. Thanks for this PR. |
|
Sorry for the delay. Your fix is now published on crates.io. Thanks again. |
LawnGnome
added a commit
to LawnGnome/gcp-bigquery-client
that referenced
this pull request
Sep 26, 2023
LawnGnome
added a commit
to LawnGnome/gcp-bigquery-client
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I seen panic with
Rows are not presentwhen execute large query.