Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy not checking tests in CI #80

Closed
silvestrst opened this issue Jun 17, 2021 · 1 comment
Closed

Clippy not checking tests in CI #80

silvestrst opened this issue Jun 17, 2021 · 1 comment

Comments

@silvestrst
Copy link

silvestrst commented Jun 17, 2021 •
edited
Loading

It seems that clippy in CI is not running over tests:

    - name: Check clippy lints
      run: cargo clippy --verbose

I think it might be useful to have an additional:

 - name: Check clippy lints
   run:` cargo clippy --tests

Unless --tests covers both cases, in which case we could just add --test to the existing run
@Cypher1
Copy link
Contributor

Cypher1 commented Jul 29, 2021

I'd recommend using

cargo clippy --all-targets

to ensure full coverage (though it does sometimes report issues twice: rust-lang/rust-clippy#4092 )

Cypher1 pushed a commit to Cypher1/manticore that referenced this issue Jul 29, 2021
Fix for Clippy not checking tests lowRISC#80
0dab955 
Small fix for 
 lowRISC#80
@Cypher1 Cypher1 mentioned this issue Jul 29, 2021
Merged
Cypher1 pushed a commit to Cypher1/manticore that referenced this issue Aug 2, 2021
@Cypher1
Fix for Clippy not checking tests lowRISC#80
f5d0c1b 
Small fix for
 lowRISC#80

Additionally allow clippy::unusual_byte_groupings, to ensure tests pass
clippy.
Cypher1 pushed a commit to Cypher1/manticore that referenced this issue Aug 2, 2021
@Cypher1
Fix for Clippy not checking tests lowRISC#80
f5e074b 
Small fix for
 lowRISC#80

Additionally allow clippy::unusual_byte_groupings, to ensure tests pass
clippy.
mcy pushed a commit that referenced this issue Aug 3, 2021
@mcy
Fix for Clippy not checking tests #80
e4e71ef 
Small fix for
 #80

Additionally allow clippy::unusual_byte_groupings, to ensure tests pass
clippy.
@mcy mcy closed this as completed Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Cypher1 @mcy @silvestrst