Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vips to upsample webp #3267

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Use vips to upsample webp #3267

merged 2 commits into from
Jun 20, 2022

Conversation

blacha
Copy link
Contributor

@blacha blacha commented Jun 17, 2022

When scaling WebP images up past 16383 x 16383 use vips scaling logic to prevent Error: webp: bad image dimensions

Fixes #3262

@blacha blacha changed the title Use vips scaling webp up fixes #3262 Use vips scaling webp up Jun 17, 2022
@blacha blacha changed the title Use vips scaling webp up Use vips to upsample webp Jun 17, 2022
src/pipeline.cc Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cd25631 on blacha:fix/scale-up-webp into 4662527 on lovell:main.

@lovell lovell merged commit a333b87 into lovell:main Jun 20, 2022
@lovell
Copy link
Owner

lovell commented Jun 20, 2022

Brilliant, thank you for fixing this (and thanks Kleis for reviewing).

@lovell lovell added this to the v0.30.7 milestone Jun 20, 2022
@blacha
Copy link
Contributor Author

blacha commented Jun 20, 2022

Awesome than you both! Libvips/sharp are amazing tools!

When do you think a release for this will happen?

@lovell
Copy link
Owner

lovell commented Jun 21, 2022

@blacha This will be part of v0.30.7, probably some time later this week ahead of the work to test the forthcoming libvips v8.13.0.

lovell added a commit that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing then extracting Webp images past 16,383 now fails from sharp 0.30.x
4 participants