-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression with 2.5.1: ArgumentError: unknown keyword #1444
Comments
Thanks for reporting this @rocket-turtle, I'm taking a look 👍 |
For starters, I can now tell why this was not captured by tests: # this works as expected
save_response(env, 200, 'test', {'test' => 'test'})
# this raises an unknown keyword: :test error
save_response(env, 200, 'test', {test: 'test'}) It turns out, Ruby 2.7 will attempt to use the last hash argument as |
I've merged a fix and will soon release this as v2.5.2 👍 |
Thank you for the fast fix.
That is interesting. |
I actually checked all the known adapters (at least those documented in awesome-faraday), and since they all support the |
Basic Info
Issue description
With the new Version I get an ruby deprecation and my test is failing:
I think the Problem is that 6799f58 added an keyword parameter to save_response and now the headers from lib/faraday/adapter.rb:62 are splitted into the arguments and cause the Problem.
Steps to reproduce
I do not know why the tests for the Adapter do not show the same error. I can investigate further if you can not reproduce the error.
The text was updated successfully, but these errors were encountered: